cpoerschke commented on a change in pull request #180:
URL: https://github.com/apache/solr/pull/180#discussion_r681101743
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -1008,6 +1008,29 @@ public boolean isShutDown() {
return isShutDown;
}
+ /**
Review comment:
> really minor but I prefer that methods, especially private ones,
_follow_ its callers so that you can follow the code reading down without
bouncing back up
interesting. my method placement choice when refactoring is usually guided
by what will result in an easier-to-review diff but before-or-after makes no
difference in this case (no pun intended) and so relocated to place the private
method after the caller as suggested, and also after another method that is
called by the caller before this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
