thelabdude commented on a change in pull request #245:
URL: https://github.com/apache/solr/pull/245#discussion_r681285311
##########
File path: solr/webapp/web/partials/security.html
##########
@@ -51,10 +51,10 @@ <h2><span>Security Settings</span></h2>
<span ng-show="manageUsersEnabled" id="realm-field">
<label for="realmName">Realm: </label><input disabled
class="input-text" type="text" id="realmName" ng-model="realmName">
</span>
- <span id="block-field"><label for="block_unknown">Block anonymous
requests?</label><input class="input-check" type="checkbox" id="block_unknown"
ng-model="blockUnknown" ng-change="onBlockUnknownChange()"
ng-true-value="'true'" ng-false-value="'false'"/><a
ng-click="showHelp('blockUnknownHelp')"><img class="help-ico"
src="img/ico/question-white.png"/></a>
+ <span id="block-field" ng-show="manageUsersEnabled"><label
for="block_unknown">Block anonymous requests?</label><input class="input-check"
type="checkbox" id="block_unknown" ng-model="blockUnknown"
ng-change="onBlockUnknownChange()" ng-true-value="'true'"
ng-false-value="'false'"/><a ng-click="showHelp('blockUnknownHelp')"><img
class="help-ico" src="img/ico/question-white.png"/></a>
Review comment:
`blockUnknown` is only valid for the basic auth plugin, so not showing
it otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
