[
https://issues.apache.org/jira/browse/SOLR-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392455#comment-17392455
]
ASF subversion and git services commented on SOLR-15486:
--------------------------------------------------------
Commit 5c960f10ff3c382224c6f802a017762cd1a9cf6c in lucene-solr's branch
refs/heads/branch_8x from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5c960f1 ]
SOLR-15486: make SolrCoreState.pauseUpdatesAndAwaitInflightRequests logic not
SolrCloud specific (#180)
Resolved Conflicts:
solr/core/src/java/org/apache/solr/core/CoreContainer.java
> consider SolrCoreState.inflightUpdatesCounter logic in ZK-unware Solr
> ---------------------------------------------------------------------
>
> Key: SOLR-15486
> URL: https://issues.apache.org/jira/browse/SOLR-15486
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> SOLR-14942 added the {{inflightUpdatesCounter}} logic to reduce leader
> election time on node shutdown.
> From my understanding of the code so far:
> * Since the earlier triggering of an election is specific to ZK-aware Solr
> then one could say that {{ContentStreamHandlerBase.handleRequestBody}} doing
> inflight update registers and deregisters is unnecessary.
> * Alternatively if waiting for inflight updates to complete (at that point
> in the shutdown sequence) is generally beneficial then one could say that the
> {{pauseUpdatesAndAwaitInflightRequests}} logic should be added for the
> ZK-unware code path in {{CoreContainer.shutdown}} also.
> Illustrative draft pull request with both options:
> https://github.com/apache/solr/pull/180
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
