gus-asf commented on pull request #265: URL: https://github.com/apache/solr/pull/265#issuecomment-904638223
> I left some comments but overall it seems this is _very_ much in progress, so it's hard for me to judge. If I recall, you were thinking of having some number of Servlets and have Jetty do some dispatch but I don't notice this. Lost in the wide ranging discussions on the list is the idea that I intend this patch to be a small but hopefully *generally* helpful step in the right direction. The idea in *this* patch is to move some code into re-usable locations and make core-container available outside the SolrDispatchFilter so future authors are not forced to add more stuff to the dispatch filter. Of course nobody is **really** forced to do anything but they would need to front-load 15h or so of yak shaving and a significant dose of ambition if they wanted to avoid expanding the filter. This patch is meant to provide a cleaner, mostly hairless yak for future use by myself and others :) I'm trying hard to think of useful, discrete steps toward the larger goals discussed, that stand alone and get them merged in chunks that are both reviewable and beneficial on their own, so that my work doesn't get so out of date that I abandon it for pain of merging, and so that others can pitch in if they want, etc. So the question is is this patch (minus AdminServlet, which is an example for review purposes, but not ready for commit at this time. I now wish I'd thought to leave a //nocommit comment to this effect in the class itself rather than just saying so in the issue) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
