dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699603869
##########
File path: gradle/generation/javacc.gradle
##########
@@ -129,17 +115,33 @@ configure(project(":solr:core")) {
// We always regenerate, no need to declare outputs.
class JavaCCTask extends DefaultTask {
- @Input
+ @InputFile
File javaccFile
Review comment:
It doesn't have to be. It can be plain Java API. We're not being fancy
with the lazy API here so I don't think we need to make things complicated?
There is a semantic difference between Input and InputFile - this was a bug.
https://docs.gradle.org/current/userguide/more_about_tasks.html#sec:up_to_date_checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
