[
https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407619#comment-17407619
]
David Eric Pugh commented on SOLR-15607:
----------------------------------------
Thanks [~janhoy] for the feedback. The intent of this PR is to instead of
assuming {{indent}} has a default, make the behavior explicit.
We found that when using {{wt=json}} with indentation, we saw a measurable
performance hit in production use, so we have set in request handler,
{{indent=false}}. This means when we query Solr, we always get the JSON
content back as a single line, which has a terrible UI.
In investigating this, I wondered if we should rethink the {{indent=true}}
being a default that was introduced in Solr 7. How many people have
indenting turned on in production use cases that would benefit by
{{indent=false}} by default, and making indentation a choice of the Query UI.
> Invert indent switch behaviour for clarity
> ------------------------------------------
>
> Key: SOLR-15607
> URL: https://issues.apache.org/jira/browse/SOLR-15607
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Admin UI
> Affects Versions: 8.8.2
> Reporter: Olivia Falk
> Assignee: David Eric Pugh
> Priority: Trivial
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the UI defaults to having indenting enabled when a query is
> performed, with a checkbox available to turn indenting off when checked.
> This change would simply have the checkbox labeled "indent" or "indent on",
> and it would be checked by default. Then a user could uncheck it to turn off
> indenting. This helps keep the UI clear instead of having the user "enable"
> a box to disable a feature.
> Also, the indent parameter would always be passed into the query so that it's
> clear to the user how it works; as it stands, we only pass `indent=false`
> when the "indent off" box is checked.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
