[
https://issues.apache.org/jira/browse/SOLR-15555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413181#comment-17413181
]
Mike Drob commented on SOLR-15555:
----------------------------------
Results from my newly added benchmarks:
{noformat}
Benchmark asyncCache enabled:size
freq mode it before patch after patch
------------------------------------------------------------------------------------------------------------------------------------------------------------------
FilterCache.filterCacheMultipleQueries true true:1
2 thrpt 9 28378.082 ± 12734.088 ops/s 35088.076 ± 942.089
ops/s
FilterCache.filterCacheMultipleQueries true true:1
50 thrpt 9 21495.362 ± 12647.104 ops/s 25839.327 ± 764.461
ops/s
FilterCache.filterCacheMultipleQueries true true:1
98 thrpt 9 17578.476 ± 967.229 ops/s 19577.575 ± 208.985
ops/s
FilterCache.filterCacheMultipleQueries true true:0
2 thrpt 9 30199.854 ± 897.983 ops/s 31464.747 ± 708.331
ops/s
FilterCache.filterCacheMultipleQueries true true:0
50 thrpt 9 11566.626 ± 12858.345 ops/s 24682.311 ± 293.798
ops/s
FilterCache.filterCacheMultipleQueries true true:0
98 thrpt 9 11555.151 ± 4570.042 ops/s 18690.725 ± 518.258
ops/s
FilterCache.filterCacheMultipleQueries true false:0
2 thrpt 9 25186.191 ± 11939.167 ops/s 33413.569 ± 453.049
ops/s
FilterCache.filterCacheMultipleQueries true false:0
50 thrpt 9 18025.521 ± 11925.387 ops/s 25418.455 ± 656.634
ops/s
FilterCache.filterCacheMultipleQueries true false:0
98 thrpt 9 18481.212 ± 839.374 ops/s 18496.592 ± 462.368
ops/s
FilterCache.filterCacheMultipleQueries false true:1
2 thrpt 9 33293.395 ± 856.547 ops/s 32808.867 ± 2724.589
ops/s
FilterCache.filterCacheMultipleQueries false true:1
50 thrpt 9 24104.896 ± 512.370 ops/s 27009.848 ± 648.946
ops/s
FilterCache.filterCacheMultipleQueries false true:1
98 thrpt 9 14479.406 ± 6231.681 ops/s 19638.359 ± 1215.859
ops/s
FilterCache.filterCacheMultipleQueries false true:0
2 thrpt 9 25777.213 ± 9925.115 ops/s 29110.730 ± 1828.892
ops/s
FilterCache.filterCacheMultipleQueries false true:0
50 thrpt 9 21521.911 ± 1983.852 ops/s 13656.487 ± 447.254
ops/s
FilterCache.filterCacheMultipleQueries false true:0
98 thrpt 9 12942.578 ± 632.246 ops/s 8308.611 ± 226.639 ops/s
FilterCache.filterCacheMultipleQueries false false:0
2 thrpt 9 12615.931 ± 16957.608 ops/s 29795.130 ± 532.184
ops/s
FilterCache.filterCacheMultipleQueries false false:0
50 thrpt 9 18788.418 ± 7961.929 ops/s 21547.886 ± 7898.048
ops/s
FilterCache.filterCacheMultipleQueries false false:0
98 thrpt 9 15432.948 ± 6863.610 ops/s 17690.268 ± 3033.541
ops/s
FilterCache.filterCacheSingleQuery true true:1
2 thrpt 9 34381.835 ± 2465.315 ops/s 33862.079 ± 1000.707
ops/s
FilterCache.filterCacheSingleQuery true true:1
50 thrpt 9 15064.433 ± 13029.216 ops/s 25798.467 ± 612.164
ops/s
FilterCache.filterCacheSingleQuery true true:1
98 thrpt 9 18277.625 ± 7980.539 ops/s 13515.394 ± 9651.340
ops/s
FilterCache.filterCacheSingleQuery true true:0
2 thrpt 9 27322.020 ± 3312.490 ops/s 29603.394 ± 12488.165
ops/s
FilterCache.filterCacheSingleQuery true true:0
50 thrpt 9 18367.121 ± 1097.602 ops/s 24049.642 ± 1921.803
ops/s
FilterCache.filterCacheSingleQuery true true:0
98 thrpt 9 12045.794 ± 5420.482 ops/s 17168.126 ± 2752.451
ops/s
FilterCache.filterCacheSingleQuery true false:0
2 thrpt 9 28450.548 ± 1198.627 ops/s 29324.900 ± 2462.891
ops/s
FilterCache.filterCacheSingleQuery true false:0
50 thrpt 9 20715.809 ± 5281.673 ops/s 14341.808 ± 13008.036
ops/s
FilterCache.filterCacheSingleQuery true false:0
98 thrpt 9 19935.259 ± 650.503 ops/s 17299.856 ± 1467.106
ops/s
FilterCache.filterCacheSingleQuery false true:1
2 thrpt 9 33137.322 ± 2752.428 ops/s 31624.194 ± 10281.634
ops/s
FilterCache.filterCacheSingleQuery false true:1
50 thrpt 9 21512.976 ± 770.741 ops/s 23770.238 ± 12487.799
ops/s
FilterCache.filterCacheSingleQuery false true:1
98 thrpt 9 19346.424 ± 6682.017 ops/s 17183.267 ± 8115.854
ops/s
FilterCache.filterCacheSingleQuery false true:0
2 thrpt 9 28311.453 ± 2527.954 ops/s 27980.698 ± 4843.644
ops/s
FilterCache.filterCacheSingleQuery false true:0
50 thrpt 9 20567.330 ± 2565.815 ops/s 13049.734 ± 3814.382
ops/s
FilterCache.filterCacheSingleQuery false true:0
98 thrpt 9 12522.544 ± 4569.608 ops/s 5955.825 ± 226.672 ops/s
FilterCache.filterCacheSingleQuery false false:0
2 thrpt 9 27349.648 ± 12944.453 ops/s 24060.260 ± 17746.410
ops/s
FilterCache.filterCacheSingleQuery false false:0
50 thrpt 9 21502.422 ± 2950.434 ops/s 21265.608 ± 2209.298
ops/s
FilterCache.filterCacheSingleQuery false false:0
98 thrpt 9 18692.777 ± 2298.015 ops/s 17108.193 ± 1019.568
ops/s
{noformat}
> Use filterCache.computeIfAbsent in SolrIndexSearcher
> ----------------------------------------------------
>
> Key: SOLR-15555
> URL: https://issues.apache.org/jira/browse/SOLR-15555
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> When multiple concurrent queries come in at the same time, in several cases
> they can trigger concurrent computations of a DocSet for the cache. We should
> investigate where this happens and possibly take care to only do a single
> computation when possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
