madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r706347715
##########
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##########
@@ -114,9 +126,12 @@ public Object init(Map<String, String> args, Object
persistence, CacheRegenerato
str = args.get(MAX_RAM_MB_PARAM);
int maxRamMB = str == null ? -1 : Double.valueOf(str).intValue();
maxRamBytes = maxRamMB < 0 ? Long.MAX_VALUE : maxRamMB * 1024L * 1024L;
- str = args.get(CLEANUP_THREAD_PARAM);
- cleanupThread = str != null && Boolean.parseBoolean(str);
- if (cleanupThread) {
+ cleanupThread = Boolean.parseBoolean(args.get(CLEANUP_THREAD_PARAM));
+ async = Boolean.parseBoolean(args.get(ASYNC_PARAM));
+ if (async) {
+ // We record futures in the map to decrease bucket-lock contention, but
need computation handled in same thread
+ executor = Runnable::run;
+ } else if (cleanupThread) {
executor = ForkJoinPool.commonPool();
Review comment:
Yea, I detour around it, and this issue existed previously. We might
want to investigate it in a follow up issue, but I'd rather not get into it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
