anshumg commented on a change in pull request #238:
URL: https://github.com/apache/solr/pull/238#discussion_r708762100
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java
##########
@@ -135,6 +153,80 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rsp.add(STATUS, OK);
}
+ private void healthCheckLegacyMode(SolrQueryRequest req, SolrQueryResponse
rsp) {
+ Integer maxGenerationLag =
req.getParams().getInt(HealthCheckRequest.PARAM_MAX_GENERATION_LAG);
+ List<String> laggingCoresInfo = new ArrayList<>();
+ boolean allCoresAreInSync = true;
+
+ // check only if max generation lag is specified
+ if(maxGenerationLag != null) {
Review comment:
good to add the check because configurations don't come with guarantees
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
