[
https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416905#comment-17416905
]
Mike Drob commented on SOLR-15333:
----------------------------------
Thanks for the patch. I took a look at it, it feels pretty straightforward!
I haven't run it yet, but from reading it, I think we would still get the
warnings initially presented in "setArgs"? Since we're not misconfiguring
anything, we are trying to set a property to the value it expects anyway.
Re: your patch -
* In {{setArgs}} can we combine the two if consecutive if statements?
* Can you add a unit test to pick up this behavior as well?
* Please add a comment to init explaining what we are doing/why we are setting
the properties directly. Most people are not fluent in reading bitwise ops.
> Solr-demo in docker uses improper configuration for
> SpatialRecursivePrefixTreeFieldType
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-15333
> URL: https://issues.apache.org/jira/browse/SOLR-15333
> Project: Solr
> Issue Type: Task
> Affects Versions: 8.8.2
> Reporter: Mike Drob
> Assignee: David Smiley
> Priority: Major
> Attachments: SOLR-15333.patch
>
>
> 4/13/2021, 4:54:42 PM
> WARN false
> x:demo
> AbstractSpatialPrefixTreeFieldType
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitNorms to be
> specified in schema,​ hardcoded behavior is omitNorms=true
> 4/13/2021, 4:54:42 PM
> WARN false
> x:demo
> AbstractSpatialPrefixTreeFieldType
> FieldType SpatialRecursivePrefixTreeFieldType does not allow
> omitTermFreqAndPositions to be specified in schema,​ hardcoded behavior
> is omitTermFreqAndPositions=true
> 4/13/2021, 4:54:42 PM
> When running solr-demo with our docker images, we get a bunch of warnings:
> {noformat}
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitNorms to be
> specified in schema,​ hardcoded behavior is omitNorms=true
> FieldType SpatialRecursivePrefixTreeFieldType does not allow
> omitTermFreqAndPositions to be specified in schema,​ hardcoded behavior
> is omitTermFreqAndPositions=true
> FieldType SpatialRecursivePrefixTreeFieldType does not allow termOffsets to
> be specified in schema,​ hardcoded behavior is termOffsets=false
> FieldType SpatialRecursivePrefixTreeFieldType does not allow termPositions to
> be specified in schema,​ hardcoded behavior is termPositions=false
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitPositions to
> be specified in schema,​ hardcoded behavior is omitPositions=true
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
