[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417612#comment-17417612
]
Jan Høydahl commented on SOLR-15209:
------------------------------------
That´s a simpler alternative, and solves the need to disable a default. I'm
positive - progress over perfection.
Aside: I wish we had a built-in way to translate such new config params to a
sysProp or envVar without adding boilerplate code to bin/solr or Java. I.e.
that SolrXmlConfig.java would look for a sysprop
"solr.solrxml.forceDefaultLegacyPlacementStrategy", and an envVar
"SOLR_SOLRXML_FORCE_DEFAULT_LEGACY_PLACEMENT_STRATEGY". That would make it much
easier to override such config in a Dockerfile or similar without messing with
solr.xml. But that is another discussion.
> Make the AffinityPlacementFactory the default placement plugin
> --------------------------------------------------------------
>
> Key: SOLR-15209
> URL: https://issues.apache.org/jira/browse/SOLR-15209
> Project: Solr
> Issue Type: Improvement
> Reporter: Andrzej Bialecki
> Assignee: Ilan Ginzburg
> Priority: Major
>
> Currently there's a lot of code in {{Assign}} dealing with the fact that we
> still support the old "legacy" replica assignment as well as the new
> plugin-based placement strategies.
> Furthermore, the "legacy" assignment is now the default even though it's
> neither robust nor optimal, except in the very simple and small clusters.
> Also, providing another plugin-based placement as the default impl. runs into
> a small complication - in the absence of any plugin config the code reverts
> to the "legacy".
> In order to promote the adoption of the new plugin-based placements we should
> make the {{AffinityPlacementFactory}} the new default placement strategy,
> selected when the explicit configuration is missing (and then create it as a
> default configuration in {{PlacementPluginFactoryLoader}}).
> I propose to re-package the "legacy" strategy as a {{PlacementPluginFactory}}
> so that it can be configured in the same way as other placement plugins.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
