cpoerschke commented on a change in pull request #313:
URL: https://github.com/apache/solr/pull/313#discussion_r718280422



##########
File path: solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java
##########
@@ -146,6 +146,7 @@ public void testSortingMPSolrIndexConfigCreation() throws 
Exception {
     final Sort expected = new Sort(new SortField(expectedFieldName, 
expectedFieldType, expectedFieldSortDescending));
     final Sort actual = sortingMergePolicy.getSort();
     assertEquals("SortingMergePolicy.getSort", expected, actual);
+    assertEquals("indexSort", expected, iwc.getIndexSort());

Review comment:
       Also interestingly V2 'get' works but V1 does not, for `indexConfig` but 
not for (say) `requestHandler`
   
   * both work
   ```
   curl "http://localhost:8983/solr/gettingstarted/config/requestHandler";
   curl 
"http://localhost:8983/api/collections/gettingstarted/config/requestHandler";
   ```
   
   * latter works, former does not
   ```
   curl "http://localhost:8983/solr/gettingstarted/config/indexConfig";
   curl 
"http://localhost:8983/api/collections/gettingstarted/config/indexConfig";
   ```
   
   https://solr.apache.org/guide/8_10/config-api.html#retrieving-the-config 
lists `indexConfig` as available top-level section.
   
   ```
   $ curl "http://localhost:8983/solr/gettingstarted/config/indexConfig";
   <html>
   <head>
   <meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
   <title>Error 404 Not Found</title>
   </head>
   <body><h2>HTTP ERROR 404 Not Found</h2>
   <table>
   <tr><th>URI:</th><td>/solr/gettingstarted/config/indexConfig</td></tr>
   <tr><th>STATUS:</th><td>404</td></tr>
   <tr><th>MESSAGE:</th><td>Not Found</td></tr>
   <tr><th>SERVLET:</th><td>default</td></tr>
   </table>
   
   </body>
   </html>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to