madrob commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r720538357
##########
File path: solr/contrib/README.md
##########
@@ -0,0 +1,31 @@
+Apache Solr HDFS Contrib module
Review comment:
Should this be under the hfs contrib directory instead of top level?
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysis",
"org.apache.solr.cloud",
"org.apache.solr.core",
+ "org.apache.solr.handler",
Review comment:
Not sure I understand what changes caused this to start failing?
##########
File path: solr/test-framework/src/java/org/apache/solr/handler/package.html
##########
@@ -0,0 +1,24 @@
+<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<!-- not a package-info.java, because we already defined this package in core/
-->
Review comment:
We probably want to look at renaming some of the packages for the moved
classes, since split packages are going to cause problems down the line anyway.
Maybe ok to do this in a follow on issue if it ends up being too much here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
