epugh commented on a change in pull request #346:
URL: https://github.com/apache/solr/pull/346#discussion_r728005236
##########
File path: solr/core/src/java/org/apache/solr/update/PeerSync.java
##########
@@ -78,6 +78,11 @@
private ShardHandler shardHandler;
private List<SyncShardRequest> requests = new ArrayList<>();
+ @VisibleForTesting
+ static final int SHARD_REQUEST_PURPOSE_GET_UPDATES = 0; // unspecified i.e.
default purpose
+ @VisibleForTesting
+ static final int SHARD_REQUEST_PURPOSE_GET_VERSIONS = 1; //
ShardRequest.PURPOSE_PRIVATE
Review comment:
My lack of Java knowledge, I'm sure you had an explicit goal, but why
isn't this just ShardRequest.PURPOSE_PRIVATE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
