dweiss commented on a change in pull request #304:
URL: https://github.com/apache/solr/pull/304#discussion_r727793877
##########
File path: gradle/validation/validate-source-patterns.gradle
##########
@@ -120,6 +120,7 @@ configure(rootProject) {
// default excludes.
exclude '**/build/**'
+ exclude '**/.idea/**'
Review comment:
I think this exclusion should stay, so it's ok.
##########
File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle
##########
@@ -82,7 +83,7 @@ if (propertyValue != null) {
logger.lifecycle("Local Lucene development repository has been detected
but won't be used.")
}
} else {
- luceneDevRepo = file("${propertyValue}").absoluteFile
+ luceneDevRepo =
file(rootDir).toPath().resolve(propertyValue).normalize().toFile()
Review comment:
Really? In this case the build script has a file method and it's not
touching the right one. It should read:
rootProject.file("${propertyValue}").absoluteFile and then it'd resolve
properly. Your version switches to Java API which is not really needed.
##########
File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle
##########
@@ -117,6 +117,7 @@ if (luceneDevRepo != null) {
.replaceFirst("^lucene-", ":lucene:")
logger.info("Substituting Lucene dependency ${moduleSelector}
with an included build project: ${projectModuleName}")
+ dependency.useTarget(project(projectModuleName))
Review comment:
I did leave you something, didn't I? Darn... it's weird I missed it -
must have had it locally (because I tested it), then removed accidently while
adding the logger line... weird. Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
