[
https://issues.apache.org/jira/browse/SOLR-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429497#comment-17429497
]
Chris M. Hostetter commented on SOLR-15629:
-------------------------------------------
bq. The original idea of just (temporarily) adding a Filter to the ROOT logger
(that DENY's an ERROR log matching the Pattern or (sub)String) is still very
viable and would be simple to implement as an alternative if someone is
interested.
About 10 seconds after I posted that commend, I realized i was forgetting the
importance of "progress, not perfection" and trying to design & build a new
race car instead of just replacing the flattires on the bicycle we have.
I'm going to re-title this Jira to match the broader goal of giving tests a way
to be very explicit about what ERROR (and ideally even WARN) log messages they
expect and force tests to "expect" these ERRORs.. but in the meantime, i'm
going to open a subtask that deals with the smaller scale objective that this
issue originally tracked – which i have a decent little patch for already
> replace SolrException.ignorePatterns with a a new test-framework Rule
> ----------------------------------------------------------------------
>
> Key: SOLR-15629
> URL: https://issues.apache.org/jira/browse/SOLR-15629
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15629.patch
>
>
> We should deprecated & remove the following code:
> * {{SolrException.log()}}
> * {{SolrException.ignorePatterns}}
> * {{SolrTestCaseJ4.ignoreException()}}
> * {{SolrTestCaseJ4.unIgnoreException()}}
> * {{SolrTestCaseJ4.resetExceptionIgnores()}}
> ...and replace with something along the lines of ... (from SOLR-15628) ...
> {quote}We should probably re-think the entire existence of
> {{SolrException.log()}} and the API design of
> {{SolrException.ignorePatterns}} – replacing all callers of
> {{SolrException.log()}} with {{logger.error()}} and use a new test-only log4j
> Filter/Appdener
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
