gerlowskija opened a new pull request #351: URL: https://github.com/apache/solr/pull/351
# Description Incremental backups store metadata files whose names are constructed in part on the name of individual shards. These filenames are then parsed later on to extract the shard name and "backup ID". The parsing in question was overly-brittle though, not accounting for the variations that shard-splitting etc. produce in shard names. This caused incremental backups to fail for any collection that had previously performed a shard-split. This commit updates the parsing logic to handle these cases more flexibly, allowing post-shardsplit backups to now succeed. # Tests See the new test file, `ShardBackupIdTest`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
