[
https://issues.apache.org/jira/browse/SOLR-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430508#comment-17430508
]
David Eric Pugh commented on SOLR-15700:
----------------------------------------
[~deploymentdog] would you be open to creating a PR for this?
Also, I looked and I see that that this is what the comment is that you are
referring to: [https://github.com/apache/solr/blob/main/solr/bin/solr#L25]
Yet the code here [https://github.com/apache/solr/blob/main/solr/bin/solr#L85]
includes some other paths, correct? So you are making them match correct?
This stuff is very hard to test, so want to make sure I grok your patch!
> Fix include path consistency in bin/solr shell wrapper
> ------------------------------------------------------
>
> Key: SOLR-15700
> URL: https://issues.apache.org/jira/browse/SOLR-15700
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Affects Versions: 8.10
> Environment: CentOS 7, Solr 8.10.1
> --
> openjdk version "11.0.12" 2021-07-20 LTS
> OpenJDK Runtime Environment 18.9 (build 11.0.12+7-LTS)
> OpenJDK 64-Bit Server VM 18.9 (build 11.0.12+7-LTS, mixed mode, sharing
> Reporter: Trevor Turner
> Priority: Minor
> Labels: easyfix, patch
> Attachments: fix-solr-sh-include-paths.patch
>
>
> The shell script {{bin/solr}} states the paths it will search for
> {{solr.in.sh}} in a comment near the top of the script, however, not all of
> these paths are consistent with the logic that actually searches for the file.
> Since one can either edit the script in their own packaging/deployment or
> simply use the {{SOLR_INCLUDE}} env variable, this doesn't pose much of a
> problem, but is a minor annoyance if configuring a package based on this
> comment.
> I've created and attached a patch that includes all paths consistently in
> both places.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
