[
https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433193#comment-17433193
]
David Smiley commented on SOLR-14290:
-------------------------------------
Wow; this is pretty bad; I'm so glad you caught it! I wonder how we as a
project could better protect ourselves from this. Perhaps if
[https://github.com/apache/solr-sandbox] consumed a snapshot version, we might
know. There's like nothing there right now but there will be.
BTW please, no, lets not use PowerMock or a java agent. Granted I don't know
the specifics yet but those solutions are choices of last resort to a problem.
> Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x
> ----------------------------------------------------------------
>
> Key: SOLR-14290
> URL: https://issues.apache.org/jira/browse/SOLR-14290
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: main (9.0)
> Environment: Solr Test Framework when run externally such that
> ExternalPaths.SOURCE_HOME is null
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Blocker
>
> A fix for this was provided on branch_8x in SOLR-14283 but that same fix
> won't work in java 11 due to reflection restrictions that make it impossible
> (AFAIK) to un-final a final variable. We will likely need to employ powermock
> or our own java agent based solution, or redesign the way
> ExternalPaths.determinSourceHome and ExternalPaths.SOURCE_HOME work.
> 8.5 is coming up soon and we can't release with this broken in 8.5 so I'm
> separating the more complicated 9x fix into this ticket.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
