[
https://issues.apache.org/jira/browse/SOLR-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434043#comment-17434043
]
Chris M. Hostetter commented on SOLR-15697:
-------------------------------------------
FYI: Once i backported SOLR-15628, the functionality here backported very
smoothly -- but precommit didn't like the Logger declaration in ErrorLogMuter
... it seems that the Logger declaration validation in 8x works *MUCH*
differently from main, and don't respect the {{// nowanr}} comment i included
since hte logger definition needs to be different due to the conflicting
imports from slf4j vs log4j. I spent some time trying to understand how to
play nice with the 8x checks, but ultimatley it seemed the most prudent to
special case that check for {{ErrorLogMuter.java}} (the alternative, used by
other files w/similar issues, is to exempt them from _ALL_ source pattern
checks ... and that didn't sit well with me)
> replace SolrException.ignorePatterns with something that doesn't depend on
> SolrException.log()
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-15697
> URL: https://issues.apache.org/jira/browse/SOLR-15697
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15697.patch, SOLR-15697.patch
>
>
> We should deprecated & remove the following code:
> * {{SolrException.log()}}
> * {{SolrException.ignorePatterns}}
> * {{SolrTestCaseJ4.ignoreException()}}
> * {{SolrTestCaseJ4.unIgnoreException()}}
> * {{SolrTestCaseJ4.resetExceptionIgnores()}}
> ...and replace with something that hooks directly into logj4 Filtering
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
