gerlowskija commented on a change in pull request #357:
URL: https://github.com/apache/solr-operator/pull/357#discussion_r740304414
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -1106,7 +1106,7 @@ spec:
description: Whether the backup has finished
type: boolean
persistenceStatus:
- description: Whether the backups are in progress of being
persisted
+ description: 'Whether the backups are in progress of being
persisted. This feature has been removed as of v0.5.0. TODO: Remove this field
entirely in v0.6.0'
Review comment:
[0] ditto re: maybe the TODO should be a comment?
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -71,7 +71,7 @@ spec:
description: The location to store the backup in the specified
backup repository.
type: string
persistence:
- description: Persistence is the specification on how to
persist the backup data.
+ description: 'Persistence is the specification on how to
persist the backup data. This feature has been removed as of v0.5.0. Any
options specified here will not be used. TODO: Remove this field entirely in
v0.6.0'
Review comment:
[0] It's a little odd to see a TODO comment in what (I think?) is
user-facing documentation. Should this be in a `#`-based YAML comment instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
