[
https://issues.apache.org/jira/browse/SOLR-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436951#comment-17436951
]
David Smiley commented on SOLR-15257:
-------------------------------------
{quote}combine the functionality of Filter and Query, and then gradually delete
the Filter class entirely. Is this a reasonable approach?
{quote}
Um, no. We can't modify Query (it's in Lucene and I doubt it needs anything
either). We want Filter to go away, thought we do need a Query subclass that
behaves like Filter. You could sort of look at this like renaming Filter but
Filter has public methods on it that I don't think we should preserve.
The "gradually delete the Filter class entirely" part is very accurate – and
this has been happening over the course of some existing issues.
{quote}.makeQuery helps this issue, and what specific changes need to be made
to DocSet's API?
{quote}
A DocSet.makeQuery() is an API design choice to help someone discover how to go
from a DocSet to a Query of that DocSet. It's there today via getTopFilter. I
think in this issue you could basically rename that method and implement it
differently. But any caller that calls Filter specific methods on the result
of this will need to change.
> Add DocSetQuery in lieu of DocSet.getTopFilter
> ----------------------------------------------
>
> Key: SOLR-15257
> URL: https://issues.apache.org/jira/browse/SOLR-15257
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: David Smiley
> Priority: Major
>
> With Filter going away, we still need the ability to have a Query based on a
> DocSet. This currently happens via {{DocSet.getTopFilter}}. We could add a
> {{.makeQuery}} or just provide it.
> This issue depends on changes to DocSet's API to provide a DocIdSetIterator
> given a LeafReaderContext.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
