gus-asf commented on a change in pull request #397:
URL: https://github.com/apache/solr/pull/397#discussion_r744315400
##########
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
##########
@@ -382,7 +387,8 @@ public void lifeCycleStarted(LifeCycle arg0) {
root.getServletContext().setAttribute(SolrDispatchFilter.PROPERTIES_ATTRIBUTE,
nodeProperties);
root.getServletContext().setAttribute(SolrDispatchFilter.SOLRHOME_ATTRIBUTE,
solrHome);
-
+ coreContainerProvider = new CoreContainerProvider();
+ coreContainerProvider.init(root.getServletContext());
Review comment:
This appears to be an issue in the design of CalciteSolrDriver, not
really a function of this change. The INSTANCE or the cache snould instead be a
per core container map. This could be a root of flakiness in tests? If more
than one Core container is started per JVM/classloader then the cache gets
replaced by the subsequent CoreContainer.load() call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
