janhoy commented on pull request #418: URL: https://github.com/apache/solr/pull/418#issuecomment-971734868
> Seems good... Only thought I had was that the adding of the mimetype here seemed odd, should it be added in the jetty config? Either `web.xml` or `webdefault.xml`? On the other hand, if this only matters in this handler, maybe that just confuses thinks more. Guess Solr can fetch this data from ZK and Jetty would not know how to determine mime-type. So it is really local to this handler. I don't know any other valid uses of ShowFileRequestHandler except from serving the Files screen, so perhaps this is unnecessary functionality in the first place - perhaps it should always deliver content as plaintext? Or do other apps use it to "download" files from a configset? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
