[
https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447693#comment-17447693
]
Chris M. Hostetter edited comment on SOLR-15807 at 11/22/21, 11:45 PM:
-----------------------------------------------------------------------
{quote}... I like the autocloseable more though because you can modify local
variables - smart.
{quote}
Thanks [~dweiss] , appreciate the feedback ... i don't suppose you have any
idea what's up with the ecjLintMain failure do you? ( i haven't had a chance to
dig into it yet)
----
{quote}I will try to create a sibling Sub-Task (w/patch) ASAP showing what I
had in mind for making TestRules out of this logic (or ErrorLogMuter) so you
can see what i was thinking.
{quote}
Created SOLR-15815 w/ a really rough PoC patch that depends on this one to show
what i had in mind.
(EDIT: Oh my good jira's new "block quote" display format is so fucking
confusing/uneccessary)
was (Author: hossman):
{quote}... I like the autocloseable more though because you can modify local
variables - smart.
{quote}
Thanks [~dweiss] , appreciate the feedback ... i don't suppose you have any
idea what's up with the ecjLintMain failure do you? ( i haven't had a chance to
dig into it yet)
----
{quote}I will try to create a sibling Sub-Task (w/patch) ASAP showing what I
had in mind for making TestRules out of this logic (or ErrorLogMuter) so you
can see what i was thinking.
{quote}
Created SOLR-15815 w/ a really rough PoC patch that depends on this one to show
what i had in mind.
> Add a "LogInterceptor" helpe class that makes it easy to inspect & assert
> expected log messages
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-15807
> URL: https://issues.apache.org/jira/browse/SOLR-15807
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15807-1.patch, SOLR-15807.patch
>
>
> Following on some of the ideas started/outlined in the parent task...
> we should have an easy way for a block of test code to "intercept" and make
> assertions about log messages from specific loggers (at specific log levels,
> matching specific substrings/regexes) that happen as a result of some actions
> during the test code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
