epugh commented on a change in pull request #450: URL: https://github.com/apache/solr/pull/450#discussion_r764886640
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/CreateCorePayload.java ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.client.solrj.request.beans; + +import org.apache.solr.common.annotation.JsonProperty; +import org.apache.solr.common.util.ReflectMapWriter; + +import java.util.List; +import java.util.Map; + +public class CreateCorePayload implements ReflectMapWriter { + @JsonProperty(required = true) + public String name; + + @JsonProperty + public String instanceDir; + + @JsonProperty + public String dataDir; + + @JsonProperty + public String ulogDir; + + @JsonProperty + public String schema; + + @JsonProperty + public String config; + + @JsonProperty + public String configSet; + + @JsonProperty + public Boolean loadOnStartup; + + // If our JsonProperty clone was more feature-rich here we could specify the property be called 'transient', but Review comment: should we just pick a different parameter name and not use the word transient? I.e, should we go solve this by changing somethign elsewhere so this doesnt' have this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
