mariemat commented on pull request #468: URL: https://github.com/apache/solr/pull/468#issuecomment-999677006
> Took me a second to understand this PR... Is the `waitForWatcher` critical for the path of this test? And since it's wrapped in the logging check, then it wouldn't be run? Yes, this is exactly the issue I want to fix to make the test morr robust > I wonder if the logic should be to have the waitForWatcher to happen, but then to wrap the logging in the if statement? Since that is the pattern that we use everywhere? Other logging at info level in that test was not in if statements, Iso I removed it from that only place in that file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
