janhoy commented on a change in pull request #469:
URL: https://github.com/apache/solr/pull/469#discussion_r774017366
##########
File path: dev-tools/scripts/addVersion.py
##########
@@ -44,10 +44,9 @@ def edit(buffer, match, line):
print('done' if changed else 'uptodate')
def add_constant(new_version, deprecate):
- # TODO: Modify for new SolrVersion class, see SOLR-15845
- filename = 'lucene/core/src/java/org/apache/lucene/util/Version.java'
+ filename = 'solr/core/src/java/org/apache/solr/util/SolrVersion.java'
Review comment:
Do we even have a need in Solr to know what prior versions there have
been? Or do we only need to know our own version? Any persisting of version can
happen as a `X.Y.Z` string, that can be parsed back and compared.
The Gradle build could write out a `solrVersion.properties` file into the
jar file for consumption by a very simple SolrVersion class? Just throwing out
thoughts here. Shoot them down please :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
