chatman commented on a change in pull request #403:
URL: https://github.com/apache/solr/pull/403#discussion_r777332293
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -944,6 +946,14 @@ public void load() {
});
clusterSingletons.setReady();
+ if
(NodeRoles.PREFERRED.equals(nodeRoles.getRoleMode(NodeRoles.Role.OVERSEER))) {
+ try {
+ log.info("This node is started as a preferred overseer");
Review comment:
If we are at a point where we want pluggable roles, we can easily
refactor the code to achieve that. I think it is still early enough to know all
usecases that roles can be used for in order to arrive at the right
abstractions. All of this is internal code as of now, so no backcompat will
break when we introduce a refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
