[
https://issues.apache.org/jira/browse/SOLR-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468667#comment-17468667
]
Michael Suzuki commented on SOLR-15890:
---------------------------------------
I had a quick look and I'm concerned about the spaces, should it be
includes('limit')
Case 1 where $scope.stmt is "stmt limit 2" will result in stmt + " limit 10"
when it should be 2.
Case 2 $scope.stmt is "stmt limit ", will not work with the current patch.
> Add a limit to the Admin SQL panel if one is not included in the stmt
> ---------------------------------------------------------------------
>
> Key: SOLR-15890
> URL: https://issues.apache.org/jira/browse/SOLR-15890
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Joel Bernstein
> Assignee: Joel Bernstein
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: SOLR-15890.patch
>
>
> Solr's basic select will return all results if a limit is not added to the
> SQL query. Unlimited SQL queries are not ideal from the admin SQL screen.
> It's safer to append a LIMIT clause to every SQL query that does not include
> a LIMIT, rather than surprise the user with a massive result set.
> Users can override the LIMIT by adding a LIMIT clause to their SQL statement.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
