HoustonPutman edited a comment on pull request #491: URL: https://github.com/apache/solr/pull/491#issuecomment-1006133242
> Perhaps the "distribution" assembleBinaryTgz can re-assemble the files on the fly instead of copying from the pre-built folder? Are you saying the old assembly in "packaging" did that? The old assembly merely took all the input files and put them straight into the tarball, then if you wanted a local copy of anything, it would untar the contents into the given directory. The files were never assembled in a regular directory to start. > Good catch. This will also make the image smaller, right? Maybe but we had that logic in even when the tarball had the right permissions. I say for now to be safe we just solve it like I have proposed in #498 . But we can always remove that in the future if it looks like we are safe (that would be preferable fro sure). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
