[
https://issues.apache.org/jira/browse/SOLR-15896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469798#comment-17469798
]
Christine Poerschke commented on SOLR-15896:
--------------------------------------------
*
https://github.com/apache/solr/blob/02b7590d21013c96db9349ee05a5cb3ddfd11922/solr/core/src/java/org/apache/solr/util/SolrVersion.java#L60
*
https://github.com/zafarkhaja/jsemver/blob/0.9.0/src/main/java/com/github/zafarkhaja/semver/Version.java#L599
*
https://github.com/zafarkhaja/jsemver/blob/0.9.0/src/main/java/com/github/zafarkhaja/semver/NormalVersion.java#L177
{{org.apache.solr.util.SolrVersion.toString()}} calls
{{com.github.zafarkhaja.semver.Version.toString()}} which calls
{{com.github.zafarkhaja.semver.NormalVersion.toString()}} and I suspect
{code}
- String.format("%d.%d.%d", major, minor, patch);
+ String.format(Locale.ROOT, "%d.%d.%d", major, minor, patch);
{code}
or
{code}
- String.format("%d.%d.%d", major, minor, patch);
+ String.format(Locale.English, "%d.%d.%d", major, minor, patch);
{code}
explains the issue. I don't have bandwidth to pursue this further at the moment
but perhaps someone else does.
> reproducible test failure: org.apache.solr.util.TestSolrVersion.testToString
> ----------------------------------------------------------------------------
>
> Key: SOLR-15896
> URL: https://issues.apache.org/jira/browse/SOLR-15896
> Project: Solr
> Issue Type: Test
> Reporter: Christine Poerschke
> Priority: Minor
>
> e.g.
> https://lists.apache.org/[email protected]:2022-1:%22org.apache.solr.util.TestSolrVersion.testToString%22
> {code}
> Build:
> https://ci-builds.apache.org/job/Solr/job/Solr-BadApples-Tests-main/506/
> 2 tests failed.
> FAILED: org.apache.solr.util.TestSolrVersion.testVersionComponents
> Error Message:
> org.junit.ComparisonFailure: expected:<[9.0.1]-rc1> but was:<[٩.٠.١]-rc1>
> Stack Trace:
> org.junit.ComparisonFailure: expected:<[9.0.1]-rc1> but was:<[٩.٠.١]-rc1>
> at
> __randomizedtesting.SeedInfo.seed([8435A4C21098B175:36A3663F4D780A83]:0)
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.junit.Assert.assertEquals(Assert.java:146)
> at
> org.apache.solr.util.TestSolrVersion.testVersionComponents(TestSolrVersion.java:31)
> ...
> Reproduce with: gradlew :solr:core:test --tests
> "org.apache.solr.util.TestSolrVersion.testVersionComponents" -Ptests.jvms=4
> -Ptests.haltonfailure=false -Ptests.jvmargs=-XX:TieredStopAtLevel=1
> -Ptests.seed=8435A4C21098B175 -Ptests.multiplier=2 -Ptests.badapples=true
> -Ptests.file.encoding=US-ASCII
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
