madrob commented on a change in pull request #510:
URL: https://github.com/apache/solr/pull/510#discussion_r783338351
##########
File path:
solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java
##########
@@ -684,13 +684,13 @@ public void testMultipleSorts() throws Exception {
float_vals[5] = Float.MAX_VALUE;
float_vals[6] = Float.MIN_VALUE;
float_vals[7] = 1/3f; //0.33333334
- float_vals[8] = 0.33333333f;
+ float_vals[8] = 0.33333333f; //0.33333334, intentional?
Review comment:
Floats aren't very precise. Sometimes you ask for one thing and get
another!
I'm not sure if the value was intentionally equal to the previous value, or
if this was an oversight.
```
jshell> 0.33333333f
$1 ==> 0.33333334
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
