magibney commented on a change in pull request #513:
URL: https://github.com/apache/solr/pull/513#discussion_r783523080
##########
File path:
solr/core/src/java/org/apache/solr/response/transform/RawValueTransformerFactory.java
##########
@@ -109,19 +131,8 @@ public String getName()
@Override
public void transform(SolrDocument doc, int docid) {
Object val = doc.remove(field);
- if(val==null) {
Review comment:
Thanks! ... fwiw I wouldn't have characterized this as confusing exactly
... or no more so than the proposed alternative. In any case it's hard to judge
from this particular change in isolation. Hopefully overall though this is
clearer -- or _differently_ confusing, and in a more appropriate way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
