[ 
https://issues.apache.org/jira/browse/SOLR-15919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475559#comment-17475559
 ] 

Shawn Heisey commented on SOLR-15919:
-------------------------------------

My github username is elyograg, same as on Apache Jira.  I took a look at the 
PR.  And when I looked closer at the eclipse test results, the number of 
matches for the File class in non-test code was a lot fewer than I expected.

 

!image-2022-01-13-10-21-29-824.png!

The matches for solrj WOULD be a change to public API .  But if we can get 
those before 9.0, I think that's OK.

With the bulk of File usage being in tests, I think we can tackle those 
separately and as quickly or slowly  as we want.

> Deprecate File based APIs in SolrZKClient and create new Path-based APIs
> ------------------------------------------------------------------------
>
>                 Key: SOLR-15919
>                 URL: https://issues.apache.org/jira/browse/SOLR-15919
>             Project: Solr
>          Issue Type: Task
>            Reporter: Mike Drob
>            Priority: Major
>         Attachments: image-2022-01-13-10-21-29-824.png
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> APIs like 
> {\{SolrZkClient.setData(String path, File file, boolean retryOnConnLoss)}}
> should instead support NIO Path



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to