risdenk commented on pull request #528: URL: https://github.com/apache/solr/pull/528#issuecomment-1012691706
@dsmiley copied almost exactly from: Uses Lucene `ByteArrayDataInput` and `ByteBuffersDataInput` as inspiration. * https://github.com/apache/lucene/blob/releases/lucene%2F9.0.0/lucene/core/src/java/org/apache/lucene/store/ByteArrayDataInput.java * https://github.com/apache/lucene/blob/releases/lucene%2F9.0.0/lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java#L212 minor changes to use the byte array that existed previously. The diff from https://github.com/apache/lucene/commit/b84e0c272b6e1beb29e2a22d16d1d8a2bd05a731#diff-81cd76910207cb8480920e2a4d746617f8c31c320be57542f753cab3cb6f8c3f matches almost exactly the previous code so it wasn't a bad replacement at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
