dsmiley commented on a change in pull request #525:
URL: https://github.com/apache/solr/pull/525#discussion_r784987859



##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -671,6 +671,10 @@ public void load() {
     // Always add $SOLR_HOME/lib to the shared resource loader
     Set<String> libDirs = new LinkedHashSet<>();
     libDirs.add("lib");
+    // Always add $SOLR_TIP/lib to the shared resource loader, to allow 
loading of i.e. /opt/solr/lib/foo.jar

Review comment:
       I'm further reminded of my earlier code review in which I asked that 
such stuff be the job of NodeConfig and not CoreContainer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to