[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476328#comment-17476328
]
Houston Putman commented on SOLR-14401:
---------------------------------------
The handlers where it makes sense are the SearchHandler, ExportHandler,
StreamingHandler, and UpdateHandler. Am I missing anything?
{quote}Since the metrics logic for this is in RequestHandlerBase, I suppose we
could add a protected method supportsDistributedRequests() that defaults to
false and is only implemented by a few handlers?
{quote}
That sounds good to me.
{quote}So except for a few handlers, most handlers will only have a ".distrib."
metric.
{quote}
Confused here, shouldn't they have the ".distrib." as well as the same metrics
without the ".distrib." part? (for the non-distributed requests?)
{quote} instead only add a ".local." or perhaps ".shard."
{quote}
I think "shard" makes a lot of sense, but "local" not really. (because the
request is local, whether it is from a user or distributed from another solr
node) Although I can't really think of anything better other than "originating".
> "distrib" request handler metrics should only be tracked on pertinent handlers
> ------------------------------------------------------------------------------
>
> Key: SOLR-14401
> URL: https://issues.apache.org/jira/browse/SOLR-14401
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: David Smiley
> Priority: Major
>
> SOLR-13979 in 8.4 added separate request handler metrics for distributed
> requests. However this was done for _all_ request handlers, even though it's
> mainly SearchHandler (and maybe one or two others?) where a distributed
> request is even possible. I refer to this as "metrics pollution" and it's a
> bad thing. It's more weight per handler (latency load & memory), more weight
> for Solr metrics responses, and it's also _suggestive_ that all registered
> handlers can have distributed requests when this is quite false, thus
> confusing people.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
