dsmiley commented on a change in pull request #531:
URL: https://github.com/apache/solr/pull/531#discussion_r785519547
##########
File path: dev-docs/plugins-modules-packages.adoc
##########
@@ -0,0 +1,129 @@
+= Plugins, Modules and Packages
+:toc: left
+
+This document discusses how developers can group features into Plugins,
Modules and Packages.
+
+== Definitions
+
+=== Plugin
+
+A plugin is a low level class that implements a certain Solr interface, such as
Review comment:
```suggestion
A plugin is a low level class that implements a certain Lucene or Solr
interface, such as
```
##########
File path: dev-docs/plugins-modules-packages.adoc
##########
@@ -0,0 +1,129 @@
+= Plugins, Modules and Packages
+:toc: left
+
+This document discusses how developers can group features into Plugins,
Modules and Packages.
+
+== Definitions
+
+=== Plugin
+
+A plugin is a low level class that implements a certain Solr interface, such as
+`QParserPlugin`, `AuthPlugin`, `UpdateRequestProcessor`, `QueryResponseWriter`
etc.
+See ref guide page https://solr.apache.org/guide/solr-plugins.html[Solr
Plugins] for details.
+
+=== Module
+
+Earlier referred to as "Contrib". This is a well-defined piece of
functionality that is
+separate from solr-core and produces a separate `.jar` file in the build.
Modules help
+keep the solr-core small and lean and also reduces risk by including only
needed java classes
+on the class-path. A module can contain multiple Plugins.
+
+=== Package
+
+A Package is some server-side functionality for Solr that is provisioned with
a `manifest.json`
Review comment:
I think we should say up front that this is an evolution of a module.
It *is* a module, plus metadata. As to "server-side functionality" -- lets
instead use a word we already defined above -- "plugin".
##########
File path: dev-docs/plugins-modules-packages.adoc
##########
@@ -0,0 +1,129 @@
+= Plugins, Modules and Packages
+:toc: left
+
+This document discusses how developers can group features into Plugins,
Modules and Packages.
+
+== Definitions
+
+=== Plugin
+
+A plugin is a low level class that implements a certain Solr interface, such as
+`QParserPlugin`, `AuthPlugin`, `UpdateRequestProcessor`, `QueryResponseWriter`
etc.
+See ref guide page https://solr.apache.org/guide/solr-plugins.html[Solr
Plugins] for details.
+
+=== Module
+
+Earlier referred to as "Contrib". This is a well-defined piece of
functionality that is
Review comment:
nit-pick: Prefer to start a description on what something *is*, and not
what it *is not*.
##########
File path: dev-docs/plugins-modules-packages.adoc
##########
@@ -0,0 +1,129 @@
+= Plugins, Modules and Packages
+:toc: left
+
+This document discusses how developers can group features into Plugins,
Modules and Packages.
+
+== Definitions
+
+=== Plugin
+
+A plugin is a low level class that implements a certain Solr interface, such as
+`QParserPlugin`, `AuthPlugin`, `UpdateRequestProcessor`, `QueryResponseWriter`
etc.
+See ref guide page https://solr.apache.org/guide/solr-plugins.html[Solr
Plugins] for details.
+
+=== Module
+
+Earlier referred to as "Contrib". This is a well-defined piece of
functionality that is
Review comment:
In no place here did you say a module is a set of plugins. I mean...
isn't that like the most basic description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
