dweiss commented on a change in pull request #532:
URL: https://github.com/apache/solr/pull/532#discussion_r786099863
##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -22,7 +22,7 @@ subprojects {
// per-project.
def title = "Apache Solr Search Server: ${project.name}"
def implementationTitle = "org.apache.solr"
- def legaleseDir = project(":solr").projectDir
+ def legaleseDir = getRootProject().projectDir
Review comment:
just rootDir I think is enough.
https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#org.gradle.api.Project:rootDir
##########
File path: solr/packaging/build.gradle
##########
@@ -92,13 +92,16 @@ distributions {
contents {
// TODO: This is missing module README files, as compared to 8x
+ from(rootProject.projectDir, {
Review comment:
Could be rootDir or this, fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
