janhoy commented on pull request #525: URL: https://github.com/apache/solr/pull/525#issuecomment-1015190990
> Note that there is another key place for documentation: libs.adoc. This PR already adds information to `libs.adoc` :) > That said, I really don't want to hold this PR forever I'll target this for 9.1, and by then we'll know whether the efforts are overlapping or whether there is room for both. Another thing I wanted to address is what kind of classloader the jars in `/lib` folder is added to. I have experienced before that certain types of plugins will not work in `$SOLR_HOME/lib`, you have to place them in `WEB-INF/lib`. That is super confusing. I think it is Jetty trying to isolate webapps from each other, but Solr is only one app so we should need no such extra isolation. I don't remember what kind of plugins this was, perhaps it was those with SPI loading or using reflection? Any way I think we should try to let the new`lib/` location be equivalent to `WEB-INF/lib` so it can accept any kind of plugins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
