[
https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479688#comment-17479688
]
Kevin Risden commented on SOLR-14290:
-------------------------------------
[~gus] is there a minimal reproduction test case for this? I am having a hard
time trying to see the impact here.
The fix from SOLR-14283 is just the 2 line null check to
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java right? The
issue w/ JDK 11 is adding a test for this - not the actual fix right?
> Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x
> ----------------------------------------------------------------
>
> Key: SOLR-14290
> URL: https://issues.apache.org/jira/browse/SOLR-14290
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: 9.0
> Environment: Solr Test Framework when run externally such that
> ExternalPaths.SOURCE_HOME is null
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Blocker
> Fix For: 9.0
>
>
> A fix for this was provided on branch_8x in SOLR-14283 but that same fix
> won't work in java 11 due to reflection restrictions that make it impossible
> (AFAIK) to un-final a final variable. We will likely need to employ powermock
> or our own java agent based solution, or redesign the way
> ExternalPaths.determinSourceHome and ExternalPaths.SOURCE_HOME work.
> 8.5 is coming up soon and we can't release with this broken in 8.5 so I'm
> separating the more complicated 9x fix into this ticket.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
