[
https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479700#comment-17479700
]
Gus Heck edited comment on SOLR-14290 at 1/20/22, 9:48 PM:
-----------------------------------------------------------
IIRC if you apply the patch in SOLR-14283 to main, I believe all hell breaks
loose because java 11 won't let you mess with a final anymore, which is how I
hacked a fix into 8x, and all the tests that rely on ExternalPaths.SOURCE_HOME
break with a reflection exception. (see SourceHomeNullifier in 8x) ... this was
a quick fix added immediately prior to a release to keep it from breaking all
3rd party use of our test framework, I am not normally a fan of hacking away
final like that.
was (Author: gus_heck):
IIRC if you apply the patch in SOLR-14283 to master, I believe all hell breaks
loose because java 11 won't let you mess with a final anymore, which is how I
hacked a fix into 8x, and all the tests that rely on ExternalPaths.SOURCE_HOME
break with a reflection exception. (see SourceHomeNullifier in 8x) ... this was
a quick fix added immediately prior to a release to keep it from breaking all
3rd party use of our test framework, I am not normally a fan of hacking away
final like that.
> Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x
> ----------------------------------------------------------------
>
> Key: SOLR-14290
> URL: https://issues.apache.org/jira/browse/SOLR-14290
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: 9.0
> Environment: Solr Test Framework when run externally such that
> ExternalPaths.SOURCE_HOME is null
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Blocker
> Fix For: 9.0
>
>
> A fix for this was provided on branch_8x in SOLR-14283 but that same fix
> won't work in java 11 due to reflection restrictions that make it impossible
> (AFAIK) to un-final a final variable. We will likely need to employ powermock
> or our own java agent based solution, or redesign the way
> ExternalPaths.determinSourceHome and ExternalPaths.SOURCE_HOME work.
> 8.5 is coming up soon and we can't release with this broken in 8.5 so I'm
> separating the more complicated 9x fix into this ticket.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
