Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r787223054
##########
File path: solr/core/src/java/org/apache/solr/search/DocSet.java
##########
@@ -121,7 +121,7 @@ public int andNotSize(DocSet other) {
* was generated from the top-level MultiReader that the Lucene search
* methods will be invoked with.
*/
- public abstract Filter getTopFilter();
+ public abstract DocSetQuery makeQuery();
Review comment:
No, not at all. Thanks for bringing it up. I agree that it's indeed best
for it to simply return a `Query` rather than a `DocSetQuery`. I have made the
correction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
