janhoy commented on a change in pull request #557:
URL: https://github.com/apache/solr/pull/557#discussion_r790264452
##########
File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java
##########
@@ -327,6 +327,9 @@ private static NodeConfig
fillSolrSection(NodeConfig.NodeConfigBuilder builder,
case "sharedLib":
builder.setSharedLibDirectory(value);
break;
+ case "modules":
+ builder.setModules(value);
Review comment:
Did not do that for sharedLib, so chose to keep it transparent with user
input here too. Currently the split and strip logic is done by consumer
ModuleUtils, but it could of course have been moved earlier. Guess I prefer to
not have a ton of additional logig in plain getters/setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
