[
https://issues.apache.org/jira/browse/SOLR-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482048#comment-17482048
]
Michael Gibney commented on SOLR-14595:
---------------------------------------
Thanks, Hoss. I'm happy to remove the explicit negative overrequest "feature"
(I agree it's the best way to go), and I opted for a strict approach. Anyone
who was specifying a negative overrequest in this way would likely get
different behavior now, so better fail hard than have an insidious change in
behavior.
re: {{EnumSet.allOf(FacetMethod.class)}}: yes no need to enumerate these,
thanks for pointing that out. Looping over {{FacetMethod.values()}} as of
[b4f50ae8|https://github.com/apache/solr/pull/447/commits/b4f50ae87a3d0b4d0de3dd1aafca5c9566b4a5fe]
(functionally equivalent, no need to construct an {{EnumSet}}, I think).
Hoping to commit shortly. I plan to backport to {{branch_9x}} I think -- not
sure about {{branch_9_0}}.
> json.facet subfacet 'sort:"index asc", refine:true' can return diff results
> using method:enum
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-14595
> URL: https://issues.apache.org/jira/browse/SOLR-14595
> Project: Solr
> Issue Type: Bug
> Components: Facet Module
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-14595.patch, SOLR-14595.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> jenkins found a failing seed for TestCloudJSONFacetSKGEquiv that has nothing
> to do with SKG -- it shows that using {{method:enum}} can sometimes return
> different set of buckets then {{method:smart}} when computing a facet that
> uses {{"sort":"index asc", "refine":true}} _as a subfacet_ of some other
> facet.
> (In all the cases i've been able to trigger with more targetted testing, the
> "parent facet" needs to use a sort option that cause buckets to "sort worse"
> when more data is known about them -- ie: "count asc" or SKG -- but i haven't
> determined if that's actaully neccessary to trigger the fialure)
> original jenkins failure...
> {noformat}
> master jenkins (@ 541fc984e90) ...
> [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=TestCloudJSONFacetSKGEquiv -Dtests.method=testRandom
> -Dtests.seed=356C5A0B17DE491 -Dtests.multiplier=2 -Dtests.slow=true
> -Dtests.badapples=true -Dtests.locale=en-KN -Dtests.timezone=Asia/Ho_Chi_Minh
> -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> [junit4] FAILURE 1.05s | TestCloudJSONFacetSKGEquiv.testRandom <<<
> [junit4] > Throwable #1: java.lang.AssertionError:
> rows=0&q=(field_7_multi_sds:19+OR+field_11_multi_sdsS:61+OR+field_8_multi_sdsS:45+OR+field_10_multi_sds:21+OR+field_2_multi_sdsS:28+OR+field_8_multi_sdsS:33+OR+field_10_multi_sds:54+OR+field_12_multi_ss:41)&fore=(field_5_multi_sdsS:48+OR+field_7_multi_sds:24+OR+field_13_multi_sds:61+OR+field_10_multi_sds:32+OR+field_9_multi_ss:45+OR+field_10_multi_sds:16+OR+field_11_multi_sdsS:28+OR+field_2_multi_sdsS:33+OR+field_8_multi_sdsS:43+OR+field_7_multi_sds:9)&back=(field_2_multi_sdsS:5+OR+field_9_multi_ss:16+OR+field_0_multi_ss:40+OR+field_0_multi_ss:16+OR+field_10_multi_sds:34+OR+field_10_multi_sds:58+OR+field_9_multi_ss:15+OR+field_1_multi_sds:44+OR+field_13_multi_sds:51+OR+field_10_multi_sds:21)&json.facet={"facet_1":{"method":"${method_val:smart}","limit":12,"sort":"count+asc","refine":true,"type":"terms","field":"field_12_multi_ss","facet":{"skg":{"type":"func","func":"relatedness($fore,$back)"},"facet_2":{"method":"${method_val:smart}","limit":1,"overrequest":38,"prefix":"2","sort":"index+asc","refine":true,"type":"terms","field":"field_3_multi_ss","facet":{"skg":{"type":"func","func":"relatedness($fore,$back)"},"facet_3":{"method":"${method_val:smart}","overrequest":0,"perSeg":false,"sort":"skg+desc","refine":true,"type":"terms","field":"field_8_multi_idsS","facet":{"skg":{"type":"func","func":"relatedness($fore,$back)"}}}}}}}}&_stateVer_=org.apache.solr.search.facet.TestCloudJSONFacetSKGEquiv_collection:4
> ===> Mismatch: .facet_1.buckets[8][facet_2].buckets.length:1!=0 using
> method_val=enum
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
