janhoy commented on a change in pull request #560:
URL: https://github.com/apache/solr/pull/560#discussion_r793352113
##########
File path: solr/bin/solr
##########
@@ -2264,6 +2264,7 @@ function start_solr() {
# users who don't care about useful error msgs can override in SOLR_OPTS
with +OmitStackTraceInFastThrow
"${SOLR_HOST_ARG[@]}" "-Duser.timezone=$SOLR_TIMEZONE"
"-XX:-OmitStackTraceInFastThrow" \
"-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
$SOLR_LOGS_DIR" \
+ "-Dsolr.packages.local.dir=$SOLR_TIP/contrib" \
Review comment:
Should not the bundled "modules" folder always be available? Is it even
necessary to make the local packages dir customizable like this? I mean, if you
perhaps have your own inhouse pkg that you would want to load in a "trusted"
way, you would either copy it into the "modules" folder or you'd want pkg mgr
to resolve some other location **in addition**, not instead of the 1st party
pkgs?
PS: Is it time to merge in latest master to cut everything over to "modules"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
