epugh commented on a change in pull request #574:
URL: https://github.com/apache/solr/pull/574#discussion_r794568850
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -737,10 +746,10 @@ public void load() {
zkSys.initZooKeeper(this, cfg.getCloudConfig());
if (isZooKeeperAware()) {
- pkiAuthenticationPlugin = new PKIAuthenticationPlugin(this,
zkSys.getZkController().getNodeName(),
+ pkiAuthenticationSecurityBuilder = new PKIAuthenticationPlugin(this,
zkSys.getZkController().getNodeName(),
(PublicKeyHandler) containerHandlers.get(PublicKeyHandler.PATH));
// use deprecated API for back-compat, remove in 9.0
- pkiAuthenticationPlugin.initializeMetrics(solrMetricsContext,
"/authentication/pki");
+ pkiAuthenticationSecurityBuilder.initializeMetrics(solrMetricsContext,
"/authentication/pki");
Review comment:
If this is for 9, is it possible to remove this? Or is removing this
mean other things need to happen that are orthogonal to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
