madrob commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r794647968
##########
File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
##########
@@ -234,9 +234,8 @@ public Query createDomainQuery(FacetContext fcontext)
throws IOException {
// the number of classes that have to know about the number of
possible settings on the join
// (ie: if we add a score mode, or some other modifier to how the
joins are done)
- final SolrConstantScoreQuery fromQuery = new
SolrConstantScoreQuery(fcontext.base.makeQuery());
+ final ConstantScoreQuery fromQuery = new
ConstantScoreQuery(fcontext.base.makeQuery());
// this shouldn't matter once we're wrapped in a join query, but just
in case it ever does...
- fromQuery.setCache(false);
Review comment:
The intent here looks to be that we don't want to cache the individual
sub-queries that would get wrapped in the JoinQuery later (presumably because
we are caching the whole join?)
Since lucene query doesn't have this idea of caching, we need to wrap
fromQuery in an ExtendedQuery to disable the caching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
