HoustonPutman commented on a change in pull request #572:
URL: https://github.com/apache/solr/pull/572#discussion_r794870102
##########
File path: solr/docker/templates/Dockerfile.body.template
##########
@@ -26,10 +26,11 @@
#-#
#-#
-# add symlink to /opt/solr, remove what we don't want
+# add symlink to /opt/solr, remove what we don't want.
+# Remove the Dockerfile because it might not represent the dockerfile that was
used to generate the image.
RUN set -ex; \
(cd /opt; ln -s solr-*/ solr); \
- rm -Rf /opt/solr/docs;
+ rm -Rf /opt/solr/docs /opt/solr/docker/Dockerfile;
Review comment:
We can't because it also contains `docker/scripts` which is obviously
very important 🙂 . We don't remove the other `README.md` files, so no real
reason to do it explicitly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
